Further fix of screen capture #6893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case "NodeView": | ||
| case "NoteView": | ||
| case "AnnotationView": | ||
| break; |
There was a problem hiding this comment.
this break is ambiguous in this context.
There was a problem hiding this comment.
they are followed by a default : continue statement, but break is for switch and continue is for for loop. sort of context switch..
There was a problem hiding this comment.
Looks fairly standard to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix user reported issue #6834 where preview bubble goes beyond the edge of captured PNG image. This is mainly because the position of
NodeViewwas replaced by the values ofCanvas.LeftPropertyandCanvas.TopProperty. These values should be used to compute the final offset (i.e.TranslateTransform) of image content prior to rendering it. The fix is to determine the minimum corner of the entire graph contents, and use it to offset the rendered image contents.Before this fix:
After this fix:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
Hi @ke-yu, please help to take a look at this fix, hopefully I have explained it with enough clarity. Thanks!
FYIs
Thanks for reporting this issue, @vykrum!
Hi @riteshchandawar, if this is tested working on the
masterbranch, I will then cross-merge it to release branch. Thanks!