Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
NOTE: This was previously reviewed in #6893
Fix user reported issue #6834 where preview bubble goes beyond the edge of captured PNG image. This is mainly because the position of
NodeView
was replaced by the values ofCanvas.LeftProperty
andCanvas.TopProperty
. These values should be used to compute the final offset (i.e.TranslateTransform
) of image content prior to rendering it. The fix is to determine the minimum corner of the entire graph contents, and use it to offset the rendered image contents.Before this fix:
After this fix:
Declarations
Check these if you believe they are true
*.resx
filesReviewers
Hi @ke-yu, please help to take a look at this fix, hopefully I have explained it with enough clarity. Thanks!
FYIs
Thanks for reporting this issue, @vykrum!
Hi @riteshchandawar, if this is tested working on the
master
branch, I will then cross-merge it to release branch. Thanks!