i#1569 AArch64: Fix macros to create AND,ANDs with imms. #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions that take logical immediates are not encoded with shifts. Issue: #1569 Change-Id: Ib85757d2bdb6c05008d14be47f4d706a85f4f58f
Change-Id: I3b637ac879fdc16c1b6b895b458ab13192210b28
derekbruening
approved these changes
May 16, 2018
| { | ||
| byte *pc; | ||
| instr_t *instr; | ||
|
|
||
| instr = INSTR_CREATE_and(dc, opnd_create_reg(DR_REG_X10), | ||
| opnd_create_reg(DR_REG_X9), OPND_CREATE_INT(0xFFFF)); |
There was a problem hiding this comment.
(There's an issue on auto-generating the INSTR_CREATE_ macros -- and presumably the tests as well.)
There was a problem hiding this comment.
(y) I'll check with @AssadHashmi, not sure how far he got so far. At least for the remaining NEON instructions, I try to generate most things. Except for some instructions with uncommon operands, like fmov.
core/arch/aarch64/instr_create.h
Outdated
| INSTR_CREATE_and_shift(dc, rd, rn, rm_or_imm, OPND_CREATE_LSL(), OPND_CREATE_INT(0)) | ||
| opnd_is_immed(rm_or_imm) ? instr_create_1dst_2src((dc), OP_and, (rd), (rn), (rm_or_imm)) : \ | ||
| INSTR_CREATE_and_shift(dc, rd, rn, rm_or_imm, OPND_CREATE_LSL(), \ | ||
| OPND_CREATE_INT(0)) |
There was a problem hiding this comment.
Put () around the whole thing for safety
There was a problem hiding this comment.
Done, thank you very much!
core/arch/aarch64/instr_create.h
Outdated
| INSTR_CREATE_ands_shift(dc, rd, rn, rm_or_imm, OPND_CREATE_LSL(), OPND_CREATE_INT(0)) | ||
| opnd_is_immed(rm_or_imm) ? instr_create_1dst_2src((dc), OP_ands, (rd), (rn), (rm_or_imm)) : \ | ||
| INSTR_CREATE_ands_shift(dc, rd, rn, rm_or_imm, OPND_CREATE_LSL(), \ | ||
| OPND_CREATE_INT(0)) |
There was a problem hiding this comment.
Put () around the whole thing for safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions that take logical immediates are not encoded with shifts and the
macros were broken for them.
Issue: #1569