Field Defaults: Allow default primitive w/o Lambda #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [Update] Persistence was expecting the default value to support
either `call` or `dup` but certain values like numbers and booleans
do not support `dup` since they are copy by value. Adding support
so can write `:default => 1` or `{ default: 1 }` as README
suggests with `field :actions_taken, :integer, {default: 0}`.
5 similar comments
|
@richardhsu @andrykonchin We should start adding to a |
richardhsu
deleted the
richardhsu/persistence-default-value-without-lambda
branch
|
Oh, yes sounds good! Will do that moving forward! :) |
|
@pboling please wait for my review before merging. I need at least a day to look at PR because of time zone shift |
|
@andrykonchin OK, will wait in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
either
callordupbut certain values like numbers and booleansdo not support
dupsince they are copy by value. Adding supportso can write
:default => 1or{ default: 1 }as READMEsuggests with
field :actions_taken, :integer, {default: 0}.CR @pboling @andrykonchin thanks!