Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix underflow in methane calculation #6483

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix underflow in methane calculation #6483

merged 1 commit into from
Jul 11, 2024

Conversation

peterdschwartz
Copy link
Contributor

@peterdschwartz peterdschwartz commented Jun 21, 2024 •
edited
Loading

Replace >0._r8 check in CH4Mod with a small parameter set by tiny intrinsic function. The exact value of tiny(1._r8) may depend on the compiler and machine but is on the order of 1.E-308

Tested on pm-cpu_intel and pm-cpu_gnu

Fixes #6428
[BFB]

peterdschwartz added a commit that referenced this pull request Jul 10, 2024
@peterdschwartz
Merge remote-tracking branch 'myfork/peterdschwartz/lnd/fix-ch4-under…
6159780 
…flow' into next (PR #6483)

Replace >0._r8 check in CH4Mod with a small parameter set by tiny intrinsic function.
The exact value of tiny(1._r8) may depend on the compiler and machine but is on the order of 1.E-308

Tested on pm-cpu_intel and pm-cpu_gnu

Fixes #6428
[BFB]
@peterdschwartz
Copy link
Contributor Author

merged to next

@peterdschwartz peterdschwartz merged commit fff7243 into E3SM-Project:master Jul 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkeen ndkeen ndkeen approved these changes

Assignees

@peterdschwartz peterdschwartz

Labels
bug fix PR Land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIGFPE: Floating-point exception in CH4Mod.F90
2 participants
@peterdschwartz @ndkeen