-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review response to drug hierarchy for GO vs EFO terms #32
Comments
A few thoughts about this:
|
This ticket is currently in our Icebox, but when we come back to it, we may want to consider how Mondo is approaching representation of responses to drugs (monarch-initiative/mondo#860). |
Update: the Mondo ticket has now been addressed, so I'll move this to Backlog, and when we have a chance, we could examine Mondo's approach and evaluate adopting it for EFO too. |
Updating this ticket to document recent discussion (on the GO tracker) re. obsoletion of 'response to drug' GO terms, some of which are used in EFO by GWAS curators: geneontology/go-ontology#21998 |
@paolaroncaglia @zoependlington @matentzn @eks-ebi @dosumis <style type="text/css"></style>
We will also consider adding broad 'response to' subclasses in order to differentiate between 'toxicity/adverse effects' and 'response to treatment with' in line with the GWAS cat, OTAR and ClinVar (see monarch-initiative/mondo#860). |
@dosumis @zoependlington @matentzn Work in this ticket should also address #166 |
Just an update on the manual mapping approach and the slight modification to the instructions that Nico and I discussed. Briefly we discussed adding a couple of columns for the GO nearest parent and its label. This is because (for the terms that weren't in OBA or in VT) I was originally asked to add either response to stimuli or response to chemical under go_class; but in many instances the nearest parent in GO is more specific For some other terms in GO there is a mutli-hierarchy of nearest parents so to reflect I have added all nearest parents separated by "|". In some instances and usually for EFO terms the nearest parents differ between GO and EFO (which I presume is because there was an attempt in EFO to introduce some structure which is not mirrored in GO) . Nearest parents can also differ between EFO and GO for terms that are the same |
Some of the response to chemical terms are so old that I was the creator of them. I think the nearest parents are an indicator of divergence between GO and EFO over time. |
Thanks, yes indeed, for the last example above GO added response to peptide a year ago. |
Please don't constrain the modelling based on our previous requests (e.g. #1209). We are quite keen to get this information organised in EFO and we will adapt to whatever conclusion you reach. As mentioned before, we have several datasets with response or resistance to drugs very often in the context of a disease: GWAS catalogue, ClinVar, Cancer Genome Interpreter, etc. Our biggest concern is to find an approach that scales with the amount of data generated. |
@rays22 see comments for response to terms |
As a general rule, if a drug is available in Chebi, the corresponding 'response to' term should be created in GO and imported into EFO. Review all subclasses of response to drug that currently have an EFO ID to see if an appropriate GO term could be generated to replace them.
The text was updated successfully, but these errors were encountered: