Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved measurement and biomarker representation in EFO #787

Open
zoependlington opened this issue May 2, 2019 · 3 comments
Open

Improved measurement and biomarker representation in EFO #787

zoependlington opened this issue May 2, 2019 · 3 comments
Labels

Comments

@zoependlington
Copy link
Collaborator

Measurements and clinical attributes representation (UK biobank and GWAS representation) (OTAR, GWAS). The EFO measurement hierarchy is used to annotate a number of gwas traits. Often the link to the primary trait (diagnosis or phenotype) is missing in the ontology. We need to review the EFO design pattern and how annotations are created in GWAS to reflect better what, how, then e.g. what was the trait of interest, how was it being measured, and what was the finding.

@zoependlington zoependlington changed the title Improved measurement representation Improved measurement representation in EFO May 2, 2019
@paolaroncaglia paolaroncaglia transferred this issue from EBISPOT/ontology-webpages May 12, 2020
@paolaroncaglia paolaroncaglia changed the title Improved measurement representation in EFO Improved measurement and biomarker representation in EFO May 12, 2020
@paolaroncaglia
Copy link
Collaborator

Note for self: this ticket used to be an Epic in the ebispot.github.io tracker. As it collected EFO-only tickets, we've moved it to the EFO tracker so it's more visible. We'll collect tickets about biomarkers here, too.

@paolaroncaglia
Copy link
Collaborator

paolaroncaglia commented May 12, 2020

Note for self: there are several tickets in this Epic that we need to look into; this said, at a meeting with @smnorthen and @zoependlington today, we summarised the following points:

  • Current structure of measurement and biomarker branches is too flat (and may contain errors)
  • Need to look into how to axiomatise terms to make them more useful, but make the axioms generally valid, i.e. don't restrict them by linking measurements to diseases because those inferences may not always hold true (e.g. you may want to measure glucose levels in non-diabetes patients too)
  • Grouping terms may be created if useful.
  • Also, @smnorthen wrote: "Here are a few examples of categorising biomarkers in EFO. I have removed some columns which were specific to the GWAS catalog. I have only done a few (quite a while back!), but hopefully it will give you some suggestions/ideas on re-structuring the measurement branch.". I'll attach her draft file here. EFO_Measurements_revised.xlsx

@kallia-p
Copy link
Collaborator

kallia-p commented Jan 7, 2022

@rays22 Biomarkers ticket for handover

@kallia-p kallia-p removed their assignment Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants