New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP7 で無効な参照代入を削除 #193

Merged

chihiro-adachi merged 2 commits into EC-CUBE:improve/php7 from nanasess:remove-new-reference

Apr 27, 2018

Contributor

nanasess commented Apr 27, 2018

= &new を削除
Net_UserAgent_Mobile/Net/UserAgent/Mobile/DoCoMo/ScreenInfo.php の 2088行目に残存しているが、もうガラケーは使われないと思うのでアクセスされることは無いはず。
- Net_UserAgent_Mobile ごと削除してしまってもよいかも...

nanasess added 2 commits

April 27, 2018 10:55


          new の参照代入を削除

e33ad15


          Calendar/docs, Calendar/tests は無効な参照代入が多数存在するため削除

b693fdd

coveralls commented Apr 27, 2018

Coverage remained the same at 22.474% when pulling b693fdd on nanasess:remove-new-reference into 3fc6ab3 on EC-CUBE:improve/php7.

nanasess mentioned this pull request

モバイル(ガラケー)サイトの廃止 #194

Closed

chihiro-adachi added this to the 2.17.0 milestone

chihiro-adachi merged commit edff0b8 into EC-CUBE:improve/php7

nanasess deleted the remove-new-reference branch

May 23, 2019 03:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet