Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smartyの後方互換処理の追加 #252

Merged
merged 1 commit into from
Apr 11, 2019
Merged

smartyの後方互換処理の追加 #252

merged 1 commit into from
Apr 11, 2019

Conversation

nobuhiko
Copy link
Contributor

@nobuhiko nobuhiko commented Apr 3, 2019 •
edited
Loading

2.13のテンプレートのままで2.17へ移行出来るように調整する
<!--{var=`$a`}--> がsmarty3ではエラーになるので、このケースに対応する

@coveralls
Copy link

Coverage Status

Coverage remained the same at 22.644% when pulling 6f8b739 on nobuhiko:fixTemplate into 6136c21 on EC-CUBE:improve/php7.

@chihiro-adachi chihiro-adachi added this to the 2.17.0 milestone Apr 5, 2019
@chihiro-adachi chihiro-adachi merged commit 66eed5d into EC-CUBE:improve/php7 Apr 11, 2019
@chihiro-adachi
Copy link
Contributor

@nobuhiko ありがとうございます、マージしました

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanasess nanasess nanasess approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nobuhiko @coveralls @chihiro-adachi @nanasess