SC_Query::setWhere() で設定した検索条件が無視されていたのを修正 #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobuhiko
approved these changes
May 30, 2019
|
こういうのこそテストが欲しいような |
|
別途、 商品データの Fixtures 作成しているので、それと合わせてこのテストも作成しますね |
|
ありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#261 のデグレ修正
SC_Query::setWhere() で検索条件が設定されていても、無視されていたのを修正。
商品一覧がカテゴリで絞り込みでされない状態になっていた(カテゴリで絞り込んでも全商品が表示されていた)