Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup job can put int deadlock when NOOP is not working #70

Open
lucsoft opened this issue Mar 3, 2023 · 2 comments
Open

cleanup job can put int deadlock when NOOP is not working #70

lucsoft opened this issue Mar 3, 2023 · 2 comments
Assignees
Labels
bug Something isn't working triage

Comments

@lucsoft
Copy link

lucsoft commented Mar 3, 2023

Describe the bug

Im connecting to a remote network (so it could be a package drop or something random fuzz). if it doesn't find the response for the cleanup and instead of just a timeout, it goes full ham and puts the cpu to 100% forever

To Reproduce

Connect to a remote smtp and have not perfect network stability (random package drops)

Expected behavior

A clear and concise description of what you expected to happen.

Logs

Provide the output of deno --version

deno 1.31.1 (release, x86_64-apple-darwin)
v8 11.0.226.13
typescript 4.9.4

Provide the output of your code snippet (with debug.log set to true see
hhttps://github.com/EC-Nordbund/denomailer#options )

Put log here
@lucsoft lucsoft added bug Something isn't working triage labels Mar 3, 2023
@lucsoft
Copy link
Author

lucsoft commented Mar 3, 2023

After some more digging the NOOP command fails
as the smtp server doesn't have a NOOP instruction
could this be the issue?

@lucsoft lucsoft changed the title Sometimes it deadlocks in the cleanup whileloop cleanup job can put int deadlock when NOOP is not working Mar 3, 2023
@Evertt
Copy link

Evertt commented Apr 28, 2023

Yeah it seems to me, that there should be some other kind of break in this while loop?

https://github.com/EC-Nordbund/denomailer/blob/main/client/basic/client.ts#L380

Because even when using a worker, the timeout option doesn't work if the client is in an endless while loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

3 participants