System scan complete missing a set reportSystem line, plus crashing EDDI

[Darkcyde13]

What's Wrong (please be as specific as possible)

Expected

The variable reportSystem to be set so that the System materials report check will work.

Observed

There is no reportSystem line to set this variable.

Steps to reproduce

1. Read the System scan complete script.

Configuration

• Version [Please give full version numbers here, not just "latest" or "current"]
  • EDDI Version: v4.0.2-b4
  • VoiceAttack Version: [if applicable]
• Localization [if applicable]
  • EDDI's language: [or the operating system language if EDDI's language setting is "Automatic"]
  • Voice: [Name and language]

My Investigation

Investigation Notes

As I've been looking over the System materials report, I wondered why it wasn't being run after System scan complete. Looking over the script, I realised that reportSystem is not being set.

Adding this line {set reportSystem to SystemDetails(event.systemname)} just after the {if hasSRV: should fix the problem.

I say should because when I add that line and try to run the test button for the script, EDDI always crashes. I've attached a log of this happening. It's not verbose, but this is repeatable, so I'm guessing it will be easy to find out what's going wrong.

As an addition to this, I discovered another problem, but I'll open another ticket for that. (Edit: its #2459).

EDDI Logs

eddi.log

Player journals

N/A

[Darkcyde13]

Hmm, EDDI keeps crashing whenever I try to run this script with reportSystem being set, either with the Test button , or by having it run automatically after a system scan is complete.

I've tried setting it to system.systemname, and to state.eddi_context_system_system. I've also tried setting it right after the Context section. I've even copied the default code from 'System report' that sets reportSystem, but this script always crashes EDDI or VA when it tries to set reportSystem to SystemDetails().

[Darkcyde13]

So, today I wanted to try something else, but now it's all working fine. No problems at all. This is strange, because yesterday it crashed every time I ran it with reportSystem being set, even after multiple reboots.

I've tried with event.systemname, system, systemname, and state.eddi_context_system_system. All are the same as I tested yesterday, and today all work as expected. 😕

Still, the script does need a line to set reportSystem, so the main point of this issue is still valid. 🙂

[Tkael]

Agreed, the System scan complete is mixing reportSystem and system invocations and does not actually set reportSystem. I'll fix this for the next release. I believe I've handled the cause of the crashing already (thanks to debug telemetry).