VoiceAttack: Current ship variables not being updated correctly

[F4QuArL]

After Update on EDDI 4.0.2 the command ((EDDI ship swapped)) broke for me

Under this command I run all my Shipnames with VoiceAttack and many "Begnin text Compare : [Ship name] Equal xxxxxxxx
After the Update this didn´t work anymore and EDDI didn´t even update the Ship model; Ship name, Ship size, and other variables
I first thought this was an API falure but this was not the case, i reconnected the API and the bug was still there.
I even tryed to alter the shipnames and restart VA + Eddi but this only saved the ship I was in till the next restart of VA and after that it din´t update again.

After returning back to EDDI 4.0.1 everything was back as it suposed to be without any bugs

Configuration

• Version
  • EDDI Version: 4.0.2 (10.01.2023)
  • VoiceAttack Version: v1.10.3
• Localization [if applicable]
  • EDDI's language: german
  • Voice: german

My Investigation

Investigation Notes

[Any investigation you have done, tests using default scripts and personalities, regression tests against earlier versions, etc]

EDDI Logs

eddi7.log

Player journals

Journal.2023-01-10T153738.01.log

[Tkael]

That sounds like it could be an issue with detecting changes to variables and writing new data to VoiceAttack. I'll look into it. Current ship data specifically. Any other variables that you're finding amiss?

[Tkael]

Current body variables may be similarly affected, per a Discord user's comments.

[Darkcyde13]

Following on from the above, and the other issue I linked #2486, I just tested a VA command I had for testing purposes a while ago, and it fails with EDDI v4.0.2.

Begin Integer Compare : [Ship compartments] Has Been Set
    Write [Blue] '{INT:Ship compartments}' to log
    Start Loop : Repeat From 1 to [Ship compartments], using indexer [n]
        Write [Yellow] '{INT:n}' to log
        Write [Green] '{TXT:Ship compartment {INT:n} module}.' to log
        Begin Text Compare : [{TXT:Ship compartment {INT:n} module}] Contains 'Docking'
            Write [Green] '{TXT:Ship compartment {INT:n} module} found.' to log
        End Condition
    End Loop
End Condition

It was designed to just run through all ship compartments and find a Docking Computer, but now fails to do anything. If I set the initial check to 'Has not been set' then it attempts to go through the code, but fails as it can't do Repeat from 1 to [Ship compartments] because that hasn't been set.

Rolling back to v4.0.2-rc1, and it all works correctly again.

[Tkael]

Interesting. I don't think I tinkered with anything in the code that would make 4.0.2-rc1 behave differently than 4.0.2 with respect to VoiceAttack but I'll take another look.

[slippycheeze]

I believe I'm suffering this also: no Voice Attack, but I'm getting complaints from EDDI that I have a limpet controller with no limpets. Checking my ship inventory, I have 64 tonnes of the things. So, same sort of problem, EDDI seeing an incomplete view of what my ship contains?

[Tkael]

Unable to replicate this for bodies. Fixed for ships.