Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_data - using regex to determine if EDI or NEON source could be reconsidered #94

Open
mobb opened this issue Sep 25, 2020 · 1 comment

Comments

@mobb
Copy link
Contributor

mobb commented Sep 25, 2020

today, the read_data function parses the dataset identifier (regex) to decided to decide whether the source is pasta (EDI) or NEON. That seems a little risky, since a) the formats are very similar already (see screenshot - one character different), and b) adapting to a new ID format means hunting down the regex in code. We don't have plans to add another data source, but doing so would be difficult.

Consider using a switch (or function arg) to decide which read method to use.

Screen Shot 2020-09-24 at 12 31 19 PM

@clnsmth
Copy link
Contributor

clnsmth commented Aug 3, 2021

@mobb We'll cross this bridge when we add support for another data source. The current implementation works fine for now. May I close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants