Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Chrome: User-added rules don't persist enabled/disabled state across restart #741

Closed
ghost opened this issue Nov 15, 2014 · 7 comments · Fixed by #1150
Closed

Chrome: User-added rules don't persist enabled/disabled state across restart #741

ghost opened this issue Nov 15, 2014 · 7 comments · Fixed by #1150

Comments

@ghost
Copy link

ghost commented Nov 15, 2014

When there's a site with either defective https cert, or one that I manually added (add rule set), there's no way to permanently remove that defective rule set for that site! I have to manually uncheck the site's name from the extension for it to work, every time I visit it!

Can you please provide a way to permanently remove a site?

@jsha
Copy link
Member

jsha commented Nov 18, 2014

Can you give an example of a site that you have to uncheck each time you visit? The extension is supposed to remember across visits, but there may be an issue with that logic.

Also, is this for Chrome or Firefox?

@ghost
Copy link
Author

ghost commented Nov 18, 2014

This is happening on latest Chrome Beta.

Website: http://haphost.com

There are more sites that I don't remember, and this is the only reason
I've replaced this awesome extension with "KB SSL" in the past. But decided
to come back as I really appreciate EFF's (and their contributors') work and trust them a lot more.

UPDATE: It also sometimes doesn't show the icon to uncheck the site in the address bar. This can be reproduced using the same site above. When there's a referrer (like when clicking on http://haphost.com, it shows the icon to uncheck it. But when typing "haphost.com" in the address bar, it doesn't allow me to uncheck it, as the icon is not present in the address bar.

On Nov 18, 2014 4:29 AM, "jsha" notifications@github.com wrote:

Can you give an example of a site that you have to uncheck each time you
visit? The extension is supposed to remember across visits, but there may
be an issue with that logic.

Also, is this for Chrome or Firefox?


Reply to this email directly or view it on GitHub
#741 (comment)
.

@jsha
Copy link
Member

jsha commented Nov 18, 2014

Your trust is very much appreciated!

When I visit haphost.com on Chrome Beta, I don't see a rule in the HTTPS Everywhere dropdown for haphost. Can you send a screenshot of the HTTPS Everywhere dropdown that you see?

Thanks,
Jacob

@ghost
Copy link
Author

ghost commented Nov 18, 2014

Did you add it manually using "add this site" option? I did, as I thought they have site-side cert. It turned out they have it for sign in only (https://manage.haphost.com).

Now I've just also reproduced the "forgetting" problem. HTTPS Everywhere forgets the user preference when Chrome is closed completely (as from the tray icon, or a reboot).

Just a heads up, I've also added an "update" section in my first comment, with reproduction steps of a second problem.

OS: Linux Mint Debian Edition x64 (latest updates)
Browser: Chrome Beta 39.0.2171.62 beta (64-bit)

@backspace
Copy link

👍, this is happening to me too. I manually added boingboing.net, assuming they’d serve HTTPS, which they don’t. Now, I periodically have to uncheck the site to be able to load it. There should be a facility for permanently deleting a manually added site.

@fuzzyroddis
Copy link
Contributor

I think we should increase the priority of this issue, given it's impact.

@jsha jsha changed the title Can't remove non-HTTPS sites permanently! Chrome: User-added rules don't persist enabled/disabled state across restart Jan 23, 2015
@jsha
Copy link
Member

jsha commented Jan 23, 2015

Agreed. I added the High Priority tag. @StevenRoddis, @semenko, do either of you think you might have time to work on this?

I think there are two things to fix:

  • 'Add this site' should only be available on the HTTPS version of a site. Alternately, when you click 'add this site', it should navigate you to the site while you are filling out the form, so that you have an opportunity to notice the site is broken.
  • Unchecking a custom-added rule should be persisted across browser restarts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@backspace @jsha @fuzzyroddis and others