HTTPSRules.init gets called three times during Firefox startup

[jsha]

Once in the observer for profile-after-change, twice in the observer for nsPref:changed. Since this is an expensive call, we should find a way to make sure it only happens once during startup.

[diracdeltas]

Working on a hack for this. I'm seeing that the HTTPSRules.init() call happens once for profile-after-change and twice for nsPref:changed.

[jsha]

Awesome. One other thing I noticed: The pref changed, in both cases, was security.mixed_content.block_active_content (I added this.log(WARN, "data " + data); to the callback). Makes me suspicious that something internal to HTTPS Everywhere is toggling the bit off and then on again, but I couldn't find anything doing that.

[jsha]

Ah, I don't know how I missed it at first but I think it's related to this specific watcher added in the HTTPSEverywhere constructor:

branch.addObserver("security.mixed_content.block_active_content",
this, false);

[diracdeltas]

Oops! Looks like pde fixed this in 554b4e1. Closing.