New ruleset HUP.hu #7680

Merged
merged 3 commits into from Dec 10, 2016

Projects

None yet

2 participants

@hzsolt94
Contributor

Hup.hu turned on https support today. Their certificate only contains hup.hu and www.hup.hu currently.

@hzsolt94 hzsolt94 changed the title from New ruleset Hup.hu to New ruleset HIP.hu Nov 24, 2016
@hzsolt94 hzsolt94 changed the title from New ruleset HIP.hu to New ruleset HUP.hu Nov 24, 2016
@hzsolt94
Contributor

Refactored securecookie.

@hzsolt94
Contributor
hzsolt94 commented Dec 6, 2016

@gloomy-ghost can I make any improvements to merge this?

@gloomy-ghost

Didn't have time to look though

src/chrome/content/rules/HUP.hu.xml
+ Nonfunctional hosts in *.hup.hu:
+
+ h: http redirect
+ m: certificate mismatch
@gloomy-ghost
gloomy-ghost Dec 10, 2016 Collaborator

m.hup.hu

src/chrome/content/rules/HUP.hu.xml
+ - wiki.hup.hu
+ r: connection refused
+ s: self-signed certificate
+ t: timeout on https
@gloomy-ghost
gloomy-ghost Dec 10, 2016 Collaborator

Please remove blank comments.

src/chrome/content/rules/HUP.hu.xml
+<ruleset name="HUP">
+ <target host="hup.hu" />
+ <target host="www.hup.hu" />
+ <!-- <target host="wiki.hup.hu" /> m -->
@gloomy-ghost
gloomy-ghost Dec 10, 2016 Collaborator

This line can be deleted.

@gloomy-ghost gloomy-ghost self-assigned this Dec 10, 2016
@hzsolt94
Contributor

Thank you for reviewing! Refactored as requested.

src/chrome/content/rules/HUP.hu.xml
+
+ m: certificate mismatch
+ - wiki.hup.hu
+ - m.hup.hu
@gloomy-ghost
gloomy-ghost Dec 10, 2016 Collaborator

please sort them in alphabetical order.

@hzsolt94
hzsolt94 Dec 10, 2016 Contributor

Sorry, Done.

@gloomy-ghost
Collaborator

Thanks, merged.

@gloomy-ghost gloomy-ghost merged commit 1c7c9dc into EFForg:master Dec 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gloomy-ghost gloomy-ghost removed their assignment Dec 10, 2016
@hzsolt94 hzsolt94 deleted the hzsolt94:ruleset-huphu branch Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment