This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
New ruleset HUP.hu #7680
Merged
New ruleset HUP.hu #7680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add securecookie
|
Refactored securecookie. |
|
@gloomy-ghost can I make any improvements to merge this? |
gloomy-ghost
suggested changes
Dec 10, 2016
| Nonfunctional hosts in *.hup.hu: | ||
|
|
||
| h: http redirect | ||
| m: certificate mismatch |
| - wiki.hup.hu | ||
| r: connection refused | ||
| s: self-signed certificate | ||
| t: timeout on https |
There was a problem hiding this comment.
Please remove blank comments.
| <ruleset name="HUP"> | ||
| <target host="hup.hu" /> | ||
| <target host="www.hup.hu" /> | ||
| <!-- <target host="wiki.hup.hu" /> m --> |
There was a problem hiding this comment.
This line can be deleted.
|
Thank you for reviewing! Refactored as requested. |
|
|
||
| m: certificate mismatch | ||
| - wiki.hup.hu | ||
| - m.hup.hu |
There was a problem hiding this comment.
please sort them in alphabetical order.
|
Thanks, merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hup.hu turned on https support today. Their certificate only contains hup.hu and www.hup.hu currently.