Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run selenium tests in firefox and chrome #1009

Closed
cooperq opened this issue Nov 30, 2016 · 2 comments · Fixed by #1168
Closed

Run selenium tests in firefox and chrome #1009

cooperq opened this issue Nov 30, 2016 · 2 comments · Fixed by #1168
Labels
enhancement Firefox important tests
Milestone
Privacy Badger 2.1

Comments

@cooperq
Copy link
Contributor

cooperq commented Nov 30, 2016

Right now the selenium tests run only in chrome, all of the tests should run in firefox as well so we can make sure we are not breaking either browser.
@cooperq cooperq added this to the Privacy Badger 2.1 milestone Nov 30, 2016
@cooperq cooperq mentioned this issue Jan 26, 2017
Closed
@ghostwords
Copy link
Member

ghostwords commented Jan 26, 2017 •
edited
Loading

Would be good to verify that tests would catch Chrome-only src/fingerprinting.js getting re-added in the manifest (via something breaking). We probably want to add a canvas fingerprinting detection functional test regardless ...

Should test on Firefox Beta channel too.

@cowlicks cowlicks mentioned this issue Jan 28, 2017
Merged
6 tasks
@cowlicks
Copy link
Contributor

cowlicks commented Feb 26, 2017 •
edited
Loading

@ghostwords your suggestion wasn't included in #1168, can you make a separate issue?

This was referenced Mar 23, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Firefox important tests
Projects
None yet
Milestone
Privacy Badger 2.1
Development

Successfully merging a pull request may close this issue.

Selenium tests in Firefox cowlicks/privacybadgerchrome
3 participants
@cooperq @cowlicks @ghostwords