Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated QR Code not match with CIImage generated #21

Closed
2 tasks done
Haraguroicha opened this issue Jul 24, 2017 · 2 comments · Fixed by #22
Closed
2 tasks done

Generated QR Code not match with CIImage generated #21

Haraguroicha opened this issue Jul 24, 2017 · 2 comments · Fixed by #22

Comments

@Haraguroicha
Copy link
Contributor

Haraguroicha commented Jul 24, 2017 •
edited
Loading

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

  • I have read the README.md, but there is no information I need.
  • I have searched in existing issues, but did find a same one.

Issue Description

Description

Inspect from func CIImage.generateQRCode(), the qrFilter.outputImage output correctly with following image

image

But func EFQRCodeGenerator.generate() result in following wrong image

image

Reproduce

none

Other Comment

change codes[indexY][indexX] to codes[indexX][indexY] 3 times in EFQRCodeGenerator.swift will resolve this issue
@FrankWu100
Copy link

FrankWu100 commented Jul 24, 2017 •
edited
Loading

PR!!! PLS!!!

@Haraguroicha Haraguroicha mentioned this issue Jul 24, 2017
Merged
@EyreFree
Copy link
Member

EyreFree commented Jul 25, 2017 •
edited
Loading

Fixed in 1.2.6, @Haraguroicha @FrankWu100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix for flip wrong direction of output image Haraguroicha/EFQRCode
3 participants
@Haraguroicha @FrankWu100 @EyreFree