Data.frame layers

[maelle]

Fix #75
Fix #62
Fix #85
Fix #84

I've done my best to reduce the fixtures size.

[codecov-commenter]

Codecov Report

Merging #83 (6ca0123) into master (5ada120) will increase coverage by 1.73%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   85.71%   87.44%   +1.73%     
==========================================
  Files           5        5              
  Lines         231      239       +8     
==========================================
+ Hits          198      209      +11     
+ Misses         33       30       -3     

Impacted Files	Coverage Δ
R/info.R	90.69% <100.00%> (+0.45%)	⬆️
R/layer_attributes.R	90.74% <100.00%> (+5.74%)	⬆️
R/layers.R	84.70% <100.00%> (+2.51%)	⬆️
R/client.R	84.61% <0.00%> (-1.93%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ada120...6ca0123. Read the comment docs.

[annakrystalli]

I've completed the merge but...

😭 😭 😭 Tests failing!! But they don't locally 🤷‍♀️

It looks like they are being triggered by guess_layer_format but I'm not sure why.
Could you try them @maelle ? Or do the error messages make any more sense to you?

[maelle]

I'll fetch the PR!

[maelle]

The tests pass locally for me too 😭 I'll re-launch the workflows.

[annakrystalli]

This is so sad. I'm not sure what's going on. The tests passed yesterday. Since, I merged master into this branch to resolve the merge conflicts. This means the vendor params is also now included. That I believe os the only real change. I did refresh all the fixtures after the merge (f0eff34) but they all worked mine locally.

[annakrystalli]

Digging into one error (https://github.com/EMODnet/EMODnetWFS/runs/5885060397?check_suite_focus=true#step:6:356) , of failing Error (test-filter.R:26:5): numeric filters work -- biology test:

Error: Error: GET https://geo.vliz.be/geoserver/Emodnetbio/wfs?service=WFS&version=2.0.0&typeName=Emodnetbio:mediseh_cor_abs_pnt&request=DescribeFeatureType (geo.vliz.be/geoserver/Emodnetbio/wfs-fb549b.json)

I can see a fixture for this response it is referring to (geo.vliz.be/geoserver/Emodnetbio/wfs-fb549b.json) but it's in folder tests/testthat/fixtures/biology-layers/geo.vliz.be/geoserver/Emodnetbio/ rather than ~/Desktop/EMODnetWFS/tests/testthat/fixtures/mediseh_posidonia_nodata/geo.vliz.be/geoserver/Emodnetbio