Pip 1537 nested scatter #36
Conversation
There was a problem hiding this comment.
Some small comments. I think this PR would greatly benefit from tests too. You mentioned "a test toy problem with complex subworkflows", could you add it here? I don't think we need CircleCI right now but at the minimum adding tests with pytest would be good.
|
@paul-sud: I added pytests to test subworkflows and nested scatters. I will make a new ticket/PR for CircleCI and more refactoring. |
There was a problem hiding this comment.
Overall looks OK, but we might want to consider storing the metadata JSONs for the tests instead of creating them every time. Then tests will run much faster and test fixtures will be simpler. You could still keep the WDL around in case you need to recreate them.
|
@paul-sud Yep, fixed as you suggested. |
Hot fix for nested scatters.
There is no circleci testing for croo yet.
Tested with atac, chip, hic and some toy WDLs with subworkflows and nested scatters.