Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulate notes request as StreetComplete does it #15

Closed
rugk opened this issue Feb 8, 2018 · 12 comments
Closed

Emulate notes request as StreetComplete does it #15

rugk opened this issue Feb 8, 2018 · 12 comments
Labels

Comments

@rugk
Copy link
Contributor

rugk commented Feb 8, 2018

I am trying to emulate the query, which StreetComplete uses to fetch the notes, respectively to display them, when the setting "Show all notes" is not enabled, i.e. when it only shows notes with a question mark (?) in it.

So I enter ? in the search box. For some reason, this does only work in the fast (high zoom level) mode, not in the worldwide query. (I get the message that no notes are found then.)

BTW why did you remove the fast icon for high zoom levels? It was very helpful to see, when a fast query can be made.

@rugk rugk changed the title Emulate Notes request as StreetComplete does it Emulate notes request as StreetComplete does it Feb 8, 2018
@ENT8R
Copy link
Owner

ENT8R commented Feb 8, 2018

BTW why did you remove the fast icon for high zoom levels? It was very helpful to see, when a fast query can be made.

I didn't change there anything... For me it is still visible...

So I enter ? in the search box. For some reason, this does only work in the fast (high zoom level) mode, not in the worldwide query.

That's strange... I will look if I can do something about that!

@ENT8R
Copy link
Owner

ENT8R commented Feb 8, 2018

Mmhh... It looks like this is an issue of the OSM API... I tried several things to solve this, but all resulted in an empty answer...

@ENT8R
Copy link
Owner

ENT8R commented Feb 8, 2018

The issue could be that the API can't handle URLs like this:
https://api.openstreetmap.org/api/0.6/notes/search?q=?
because there are two question marks which indicates normally the beginning of the URL parameters...

@ENT8R
Copy link
Owner

ENT8R commented Feb 8, 2018

Also it is clear that it works for the high zoom level mode, because there is no query string specified...

@ENT8R ENT8R added the bug label Feb 8, 2018
@rugk
Copy link
Contributor Author

rugk commented Feb 8, 2018

Ah, I see. Could you try to HTML encode the question mark, i.e., ?? Or did you test that already?

@ENT8R
Copy link
Owner

ENT8R commented Feb 8, 2018

Doesn't work either...

@ENT8R
Copy link
Owner

ENT8R commented Mar 9, 2018

I tried again to find a solution to fix this, but I could not find anything. So this seems to be an unresolveable issue for now. If somebody has another idea how this might work, just write it here!

@ENT8R ENT8R closed this as completed Mar 9, 2018
@rugk
Copy link
Contributor Author

rugk commented Mar 9, 2018

Can you somehow report it to the ones responsible for the notes API? Or do you know where to report such things?

As it just looks like an issue with their API…

@ENT8R
Copy link
Owner

ENT8R commented Mar 9, 2018

True... I think the openstreetmap/openstreetmap-website repository is responsible for the API. I will open a new issue there.

@ENT8R
Copy link
Owner

ENT8R commented Mar 10, 2018

Got a response in openstreetmap/openstreetmap-website#1781 and this is sadly not fixable...

@Lee-Carre
Copy link

Makes me wonder how @streetcomplete does it. I'd assume (read: guess) that it downloads all notes in the area, and filters locally. I recall that toggling the ‘show all notes’ (default is only questions) option doesn't trigger a rescan, only a redraw of what's displayed.

@westnordost ?

@westnordost
Copy link

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants