Aggregate Bug #79

[gerneio]

Proposed fix for: #79

Untested with code in this form since I do not have a Node.js or Angular environment setup. However it was tested with alterations to the Browersified version. Check out this fiddle.

P.S. First Pull Request :)

[coveralls]

Coverage increased (+0.0004%) to 99.804% when pulling 0369611 on gerneio:patch-1 into bb1984a on ENikS:master.

[ENikS]

Seems to have an issue with build.

[gerneio]

I can't really make out whatever it's complaining about.

[ENikS]

485 lib/linq.ts(193,66): error TS2345: Argument of type 'A' is not assignable to parameter of type 'number'.

[ENikS]

Could you please explain what exactly are you doing?

[gerneio]

I think I figured it out. Also, I implemented the exact solution I proposed in the issue, which I did explain partly why it should be done like that. Although I'm sure there are better ways.

[gerneio]

Awesome! Looks like the checks passed!

[ENikS]

Could you be so kind and add an extra test for the condition you are trying to fix?

[gerneio]

Whats the proper way to go about that?

[gerneio]

Add it to immediate.ts in test under the 'Aggregate' area?

[ENikS]

Just add it here

[ENikS]

Almost there

test/immediate.ts(42,70): error TS2345: Argument of type '(c: number, n: string) => string' is not assignable to parameter of type '(aggr: number, x: string) => number'.

Type 'string' is not assignable to type 'number'.

[gerneio]

Almost indeed! I know nothing of TypeScript, as far as coding it, but makes sense that I'm seeing these kind of errors. Browser JS is too lenient, but that's the way I like it.

I just removed one of the test cases since it was only pertinent to how the browserfied code would handle it.

Boom! Success!

[ENikS]

Thank you for your help!

[gerneio]

No problem. Thanks for bearing with me. I've got my foot in the door now.

[gerneio]

BTW, is that browserfied version hosted on the NPM CDN updated automatically through some linked process, or is that a manual update process? If so, any idea when it can be updated?

[ENikS]

It should be automated. Path includes the version...

[gerneio]

Hmmm I feel stupid for not being able to figure this out but I've loaded it from this link
https://unpkg.com/linq-es2015@2.4.33/lib/linq.js and https://unpkg.com/linq-es2015@2.4.33/dist/linq.js, yet I still don't see the changes. I even tried just the root path (https://unpkg.com/linq-es2015) so that it would auto direct to the latest version, but same as the lib one. Thought it may have been caching it, but no difference. Perhaps I'll just check tomorrow and all will be fine!

[ENikS]

@2.4.33 - is the version