Why don't we stop unix_server from listening in shutdown stage as well?

[Elliot438b]

eos/plugins/http_plugin/http_plugin.cpp

Line 550 in 59626f1

my->https_server.stop_listening();

add

      if(my->unix_server.is_listening())
         my->unix_server.stop_listening();

[jgiszczak]

We should also unlink the socket file. Pull requests gratefully accepted. Please branch from the develop branch.

[spoonincode]

We should also unlink the socket file

Already does that

[Elliot438b]

@spoonincode Can you kindly show me the position of source code?

[spoonincode]

eos/plugins/http_plugin/include/eosio/http_plugin/local_endpoint.hpp

Line 205 in 59626f1

::unlink(m_acceptor->local_endpoint().path().c_str());

[spoonincode]

oh and here too, so it looks like stop_listenting() should remove it

eos/plugins/http_plugin/include/eosio/http_plugin/local_endpoint.hpp

Line 435 in 59626f1

::unlink(m_acceptor->local_endpoint().path().c_str());

[Elliot438b]

Yes, I think the destructor is not enough. The shutdown stage needs explicitly call.

[spoonincode]

Fix merged