Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[docs] how-to-submit-a-transaction.md suggestion / change request #807

Open
b1bart opened this issue Oct 21, 2020 · 1 comment
Open

[docs] how-to-submit-a-transaction.md suggestion / change request #807

b1bart opened this issue Oct 21, 2020 · 1 comment
Labels
documentation Requires attention of documentation team. e.g. documentation is expected to be generated.

Comments

@b1bart
Copy link

b1bart commented Oct 21, 2020

File: [docs/how-to-guides/01_how-to-submit-a-transaction.md](https://github.com/EOSIO/eosjs/blob/develop/docs/how-to-guides/01_how-to-submit-a-transaction.md)

This example and the README use a blocksBefore of 3. It seems like useLastIrreversible is a safer default for all how-to guides with the blocksBefore being something discussed as an additional option.

This has the added benefit of generating the refBlockNum and refBlockPrefix based on the results of get_info rather than issuing an additional get_block

@gleehokie
Copy link

Same change needs to be made to https://github.com/EOSIO/eosjs/blob/master/README.md. There may be other docs too that should be changed.

Note, this can prevent some of the micro forking + invalid TAPOS related issues that have been reported.

@iamveritas iamveritas added the documentation Requires attention of documentation team. e.g. documentation is expected to be generated. label Oct 21, 2020
@gleehokie gleehokie changed the title [docs] Suggestion / Change Request [docs] how-to-submit-a-transaction.md suggestion / change request Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Requires attention of documentation team. e.g. documentation is expected to be generated.
Projects
None yet
Development

No branches or pull requests

3 participants