Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: emit mapmounted event #1007

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Feat: emit mapmounted event #1007

merged 5 commits into from
Jun 10, 2024

Conversation

RobertOrthofer
Copy link
Contributor

@RobertOrthofer RobertOrthofer commented Jun 5, 2024

Implemented changes

With this PR a CustomEvent mapmounted is fired after the map is mounted. This is the earliest possibility i have found to emit a useful event, since I don't think an event inside the constructor of the EOxMap can realistically be listened to.
The detail of the event is the openlayers-map, the targetElement of the map should always be defined at that point.

Checklist before requesting a review

closes #914

@RobertOrthofer RobertOrthofer changed the title feat: emit mapmounted event Feat: emit mapmounted event Jun 5, 2024
@RobertOrthofer RobertOrthofer marked this pull request as ready for review June 6, 2024 08:16
Copy link
Member

@StefanBrand StefanBrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straightforward solution. 👍

Adding @viktoraronfarkas for information

@silvester-pari silvester-pari merged commit 9bdb5aa into main Jun 10, 2024
3 checks passed
@silvester-pari silvester-pari deleted the map/feat/emit-mounted branch June 10, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger an event that signals when OL map has mounted
3 participants