Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable/disable compare #1100

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Conversation

silvester-pari
Copy link
Collaborator

@silvester-pari silvester-pari commented Jul 17, 2024

Implemented changes

This PR adds a new functionality to the eox-map-compare and allows to toggle the comparison mode via the new enabled attribute:

  • enabled="first" only shows the first map
  • enabled="second" only shows the second map
  • enabled (undefined or any other truthy value; default) shows both maps

This effectively allows enabling/disabling the comparison in a flexible way.

Screenshots/Videos

Checklist before requesting a review

Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit 5026df7
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/6697cb6bd6939d0008d04549
😎 Deploy Preview https://deploy-preview-1100--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@silvester-pari silvester-pari changed the title Map/feat/enable disable compare feat: enable/disable compare Jul 17, 2024
Copy link
Member

@santilland santilland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this approach, it allows us to enable/disable comparison, but also easy implementation of a compare toggle button instead of a slider, from my side happy if this is merged!

@silvester-pari silvester-pari marked this pull request as ready for review July 17, 2024 13:51
@silvester-pari silvester-pari merged commit c7ee092 into main Jul 17, 2024
7 checks passed
@silvester-pari silvester-pari deleted the map/feat/enable-disable-compare branch July 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants