feat: loading indicator map control #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eoxelements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
RobertOrthofer
force-pushed
the
map/feat/spinner
branch
from
a00c07d
to
f5d24c3
Compare
RobertOrthofer
force-pushed
the
map/feat/spinner
branch
from
f5d24c3
to
d845367
Compare
silvester-pari
requested changes
Aug 5, 2024
There was a problem hiding this comment.
Thank you for this; since in the other elements we do mostly configuration via CSS variables, could this be an option here as well? So instead of passing an SVG as string, make it overwriteable via CSS variables?
Edit: On the other hand, this currently allows more flexibilty as it would allow setting an e.g. GIF or even a video as loading animation. Fine for me to keep it this way, maybe somethign to consider during our future refactoring.
silvester-pari
approved these changes
Aug 5, 2024
silvester-pari
changed the title
silvester-pari
changed the title
|
That was exactly my thought process... I'd vote in favor of this option at the moment until we have a real-world problem that would demand the other approach |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes
This PR implements a Loading Indicator Control for the map element as described in #911, providing a default SVG graphic.
possible options for this control:
type:"small"or"fullscreen"(defaults to"small")opacity: opacity of the spinner from 0 to 1spinnerSvg: optional SVG as markdown as string, should already provide the desired animation ("<svg xmls... </svg>")Two stories have been added, because the different types look quite different. Most of the time the "small" type should be sufficient.
Screenshots/Videos
Screen.Recording.2024-08-02.at.12.16.14.mov
Screen.Recording.2024-08-02.at.12.23.16.mov
Checklist before requesting a review