-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added optional extent for the registerProjection function #1205
Conversation
✅ Deploy Preview for eoxelements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per eodash v4 implementation, approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this addition, please add some description to the PR, and ideally we would also include the extent in a test. I'll see if I can prepare something in this regard! Edit: it isn't much effort to add a very basic test (like passing the extent and then checking with getExtent
, but this is probably not too useful), but didn't get further due to lack of projection knowledge...
Question: is the extent
parameter only relevant for registerProjection()
, or also for registerProjectionFromCode()
?
Implemented changes
This PR adds
extent
as an optional third parameter to theregisterProjection
function. This allows setting the validity extent for the set projection. Details see the corresponding OL docs.Checklist before requesting a review