Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added optional extent for the registerProjection function #1205

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

santilland
Copy link
Member

@santilland santilland commented Aug 8, 2024

Implemented changes

This PR adds extent as an optional third parameter to the registerProjection function. This allows setting the validity extent for the set projection. Details see the corresponding OL docs.

Checklist before requesting a review

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit bc8422a
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/66b9f6b05bbbcd00085d8813
😎 Deploy Preview https://deploy-preview-1205--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@lubojr lubojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per eodash v4 implementation, approve

Copy link
Collaborator

@silvester-pari silvester-pari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition, please add some description to the PR, and ideally we would also include the extent in a test. I'll see if I can prepare something in this regard! Edit: it isn't much effort to add a very basic test (like passing the extent and then checking with getExtent, but this is probably not too useful), but didn't get further due to lack of projection knowledge...

Question: is the extent parameter only relevant for registerProjection(), or also for registerProjectionFromCode()?

elements/map/helpers.ts Show resolved Hide resolved
elements/map/helpers.ts Outdated Show resolved Hide resolved
elements/map/helpers.ts Outdated Show resolved Hide resolved
@silvester-pari silvester-pari merged commit cbfc366 into main Aug 12, 2024
7 checks passed
@silvester-pari silvester-pari deleted the map/feat/projectionextent branch August 12, 2024 11:53
@github-actions github-actions bot mentioned this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants