Fix sorting on mobile and with hidden layers #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tool-button-hover-highlight
…layercontrol/fix/mobile-sorting
This reverts commit 870cfb8.
fix: loop through layers and remove/add via index
silvester-pari
changed the title
silvester-pari
approved these changes
Nov 29, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces three new things:
change:lengthlistener was already set on a collection before adding/replacing a new onechange:lengthWhile the first two change improve mobile performance, the third one was necessary for improved stability when dealing with hidden or optional layers.
Fixes #302
Fixes #455