Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Display of drawn feature #371

Merged
merged 18 commits into from
Nov 15, 2023

Conversation

srijitcoder
Copy link
Collaborator

@srijitcoder srijitcoder commented Oct 26, 2023

What is this PR about (Based on #136)

  • List of drawn features
  • Select individual feature from this list
  • Hover and highlight which feature is listed down
  • Select and zoom in to the selected feature
  • Delete individual feature
  • List gets updated as we draw
  • Enable it using show-list attribute
image

Demo - Loom link here

Copy link
Collaborator

@silvester-pari silvester-pari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Really clean and works well.

A future evolution of this could be that the feature selection also works "the other way round", meaning selection of a feature on the map highlights the drawn feature, but this is nothing to be considered in the first version.

elements/drawtools/src/helpers.js Outdated Show resolved Hide resolved
elements/drawtools/src/style.eox.js Outdated Show resolved Hide resolved
elements/drawtools/src/style.eox.js Outdated Show resolved Hide resolved
elements/drawtools/src/components/list.js Outdated Show resolved Hide resolved
elements/drawtools/src/components/list.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@silvester-pari silvester-pari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, it would be great to not include the formatting changes, as explained in #370.

@silvester-pari silvester-pari merged commit 43753b6 into EOX-A:main Nov 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants