fix: make sure a fallback layer id is rendered in time in order to support sorting #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvester-pari
changed the title
srijitcoder
reviewed
Jan 17, 2024
Comment on lines
+8
to
+16
| * @param {import("lit").LitElement} that - The LitElement instance. | ||
| */ | ||
| // | ||
| export default function checkProperties(collection, idProperty, titleProperty) { | ||
| export default function checkProperties( | ||
| collection, | ||
| idProperty, | ||
| titleProperty, | ||
| that | ||
| ) { |
There was a problem hiding this comment.
Yeah, this PR looks good to me because checkProperties() is a part of /helpers, and in this case, we don't define the actual instance name like EOxLayerControlLayerList. Therefore, that seems to be the best property name, as this function can be reused in other components.
Additionally, according to the logic, it also makes sense to re-render the component if the id or title changes using requestUpdateNecessary.
srijitcoder
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional
requestUpdate()after the initialpropertyCheck(), to force the DOM to re-render. The reason for this is that SortableJS needs the layeridpresent in order to work correctly.The
requestUpdate()is only called in case it is needed, e.g. if theidortitlewere changed by thepropertyCheck().Fixes #584.