Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Render attributes via comment tags #700

Merged

Conversation

srijitcoder
Copy link
Collaborator

@srijitcoder srijitcoder commented Feb 28, 2024

Implemented changes

  • Added improved markdown-it-decorate
    • Converted to ES6
    • Added comments
    • We can expand it in the future based on adding new features to it.
  • Example markdown
## Hero World section <!--{.some-comment}-->
Some text with red color <!--{#red-color style="color:red;"}-->
  
![Image](https://www.gstatic.com/prettyearth/assets/full/14617.jpg)<!-- {width=300} -->

Screenshots/Videos

image

Checklist before requesting a review

@srijitcoder srijitcoder linked an issue Feb 28, 2024 that may be closed by this pull request
@srijitcoder srijitcoder marked this pull request as ready for review February 28, 2024 12:03
@silvester-pari silvester-pari merged commit 83c2139 into main Feb 28, 2024
3 checks passed
@silvester-pari silvester-pari deleted the storytelling/feature/markdown-it-decorate-improved branch February 28, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render attributes via comment tags
2 participants