-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: geolocation control #769
Merged
Merged
+278
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because of https issues
element-getter set property on heading change
RobertOrthofer
changed the title
initial version of geolocation control
map/feat/geolocation
Mar 21, 2024
There might be a cleaner way for the positioning (css injection?) of the button element. Right now it is assumed that the default zoom-buttons are available, as this is most likely the most common setup. |
silvester-pari
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
StefanBrand
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes
This PR brings a custom Geolocation-control as defined in #562, that can be used just like any other
ol
-control. The user has to agree to the location-prompt by the browser, which will only show up when served via https (which is also true for testing, workarounds like ngrok or mkcert will be needed).The
centerWhenReady
-prop will pan the view to the user position on the first update of the geolocator.Rotation is not implemented by default, but the
heading
-property of the position feature is set, so by setting thestyle
-property of the geolocation control a rotation get be set by accessing that property via style expressions.(to enable tracking the heading,
highAccuracy
andtrackHeading
have to be set).With
trackAccuracy
the accuracy feature will be shown in addition to the position feature, indicating possible low accuracy of the sensor.A custom Icon for the button can be set via the
buttonIcon
-prop. The button element get be retrieved viaGeolocation.getElement()
Checklist before requesting a review