Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: geolocation control #769

Merged
merged 10 commits into from
Mar 22, 2024
Merged

feat: geolocation control #769

merged 10 commits into from
Mar 22, 2024

Conversation

RobertOrthofer
Copy link
Contributor

@RobertOrthofer RobertOrthofer commented Mar 20, 2024

Implemented changes

This PR brings a custom Geolocation-control as defined in #562, that can be used just like any other ol-control. The user has to agree to the location-prompt by the browser, which will only show up when served via https (which is also true for testing, workarounds like ngrok or mkcert will be needed).

The centerWhenReady-prop will pan the view to the user position on the first update of the geolocator.

Rotation is not implemented by default, but the heading-property of the position feature is set, so by setting the style-property of the geolocation control a rotation get be set by accessing that property via style expressions.
(to enable tracking the heading, highAccuracy and trackHeading have to be set).

With trackAccuracy the accuracy feature will be shown in addition to the position feature, indicating possible low accuracy of the sensor.

A custom Icon for the button can be set via the buttonIcon-prop. The button element get be retrieved via Geolocation.getElement()

Checklist before requesting a review

@RobertOrthofer RobertOrthofer changed the title initial version of geolocation control map/feat/geolocation Mar 21, 2024
@RobertOrthofer RobertOrthofer marked this pull request as ready for review March 21, 2024 15:31
@RobertOrthofer
Copy link
Contributor Author

There might be a cleaner way for the positioning (css injection?) of the button element. Right now it is assumed that the default zoom-buttons are available, as this is most likely the most common setup.

@silvester-pari silvester-pari linked an issue Mar 21, 2024 that may be closed by this pull request
Copy link
Collaborator

@silvester-pari silvester-pari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@silvester-pari silvester-pari changed the title map/feat/geolocation feat: geolocation control Mar 22, 2024
@silvester-pari silvester-pari merged commit 10ae84b into main Mar 22, 2024
3 checks passed
@silvester-pari silvester-pari deleted the map/feat/geolocation branch March 22, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geolocation with feature display
3 participants