Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delayed location popup for geolocation #825

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

RobertOrthofer
Copy link
Contributor

@RobertOrthofer RobertOrthofer commented Apr 8, 2024

Implemented changes

This PR implements the idea of a delayed browser popup (as described in #793). If the geolocation-control has the centerWhenReady-option set to false, the browser popup will appear only when the control button is clicked. As soon as the permission is granted, the map will pan to the newly created location feature (as described in this comment).

The story as been updated to display this behaviour, preventing the location-popup to show immediately when storybook is opened.

Checklist before requesting a review

@RobertOrthofer RobertOrthofer changed the title delayed location popup for geolocation feat: delayed location popup for geolocation Apr 8, 2024
@RobertOrthofer RobertOrthofer marked this pull request as ready for review April 8, 2024 10:21
@silvester-pari silvester-pari merged commit f9e5481 into main Apr 8, 2024
3 checks passed
@silvester-pari silvester-pari deleted the map/feat/delayedGeolocation branch April 8, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants