feat: delayed location popup for geolocation #825
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes
This PR implements the idea of a delayed browser popup (as described in #793). If the geolocation-control has the
centerWhenReady
-option set tofalse
, the browser popup will appear only when the control button is clicked. As soon as the permission is granted, the map will pan to the newly created location feature (as described in this comment).The story as been updated to display this behaviour, preventing the location-popup to show immediately when storybook is opened.
Checklist before requesting a review