Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: infinite rendering loop #875

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Conversation

srijitcoder
Copy link
Collaborator

@srijitcoder srijitcoder commented Apr 19, 2024

Implemented changes

  • Made updateMethod() part of firstUpdate() and removed updated from main.js and layer-list.js

Screenshots/Videos

Before

Screen.Recording.2024-04-19.at.3.58.09.PM.mov

After

Screen.Recording.2024-04-19.at.3.58.34.PM.mov

Checklist before requesting a review

@srijitcoder srijitcoder added bug Something isn't working layercontrol labels Apr 19, 2024
@srijitcoder srijitcoder linked an issue Apr 19, 2024 that may be closed by this pull request
@srijitcoder srijitcoder marked this pull request as ready for review April 19, 2024 10:32
Copy link
Member

@santilland santilland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to solve the issue that appears when integrating it into the eodash client, so i think we are good to go! Thank you for finding the issue!

@silvester-pari silvester-pari changed the title Performance issue when layercontrol is included fix: infinite rendering loop Apr 22, 2024
@silvester-pari silvester-pari merged commit 2f7dd5e into main Apr 22, 2024
3 checks passed
@silvester-pari silvester-pari deleted the layercontrol/fix/performance-issue branch April 22, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working layercontrol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance issue when layercontrol is included (in vue app)
3 participants