-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improved standard ol map config export #944
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests pass and i already tested integration in eodash, should also fix the getsource issue. I think this is ready to be merged |
Thanks, we will have a look at openlayers/openlayers#15826 and add support for vector source styling once the fix has made its way into ol. |
silvester-pari
approved these changes
May 15, 2024
silvester-pari
added a commit
that referenced
this pull request
May 15, 2024
This reverts commit ba20a5f.
santilland
pushed a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes
The previous config extraction was only considering type but was missing extraction of further properties, these have now been added for WMS, TiledWMS, XYZ config options.
For Vector sources it is not possible to retrieve the original style object (will possibly be fixed by OL)
Checklist before requesting a review