Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved standard ol map config export #944

Merged
merged 7 commits into from
May 15, 2024

Conversation

santilland
Copy link
Member

@santilland santilland commented May 14, 2024

Implemented changes

The previous config extraction was only considering type but was missing extraction of further properties, these have now been added for WMS, TiledWMS, XYZ config options.
For Vector sources it is not possible to retrieve the original style object (will possibly be fixed by OL)

Checklist before requesting a review

@santilland
Copy link
Member Author

Tests pass and i already tested integration in eodash, should also fix the getsource issue. I think this is ready to be merged

@silvester-pari
Copy link
Collaborator

Thanks, we will have a look at openlayers/openlayers#15826 and add support for vector source styling once the fix has made its way into ol.

@silvester-pari silvester-pari merged commit ba20a5f into main May 15, 2024
3 checks passed
@silvester-pari silvester-pari deleted the map/feat/ol-config-export branch May 15, 2024 11:21
silvester-pari added a commit that referenced this pull request May 15, 2024
santilland pushed a commit that referenced this pull request May 16, 2024
* Revert "feat: improved vanilla ol map config export (#944)"

This reverts commit ba20a5f.

* Revert "feat: config getter transforming native OL state (#926)"

This reverts commit 14c81de.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants