Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent reaction to undefined zoom #961

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

silvester-pari
Copy link
Collaborator

@silvester-pari silvester-pari commented May 16, 2024

Implemented changes

This PR introduces a small check to the zoom setter if the value is actually defined, as setting undefined resulted in a blank map.

Checklist before requesting a review

@silvester-pari silvester-pari marked this pull request as ready for review May 16, 2024 13:28
Copy link
Contributor

@RobertOrthofer RobertOrthofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, can't think of any real side effect right now...

@silvester-pari silvester-pari merged commit 4dcb512 into main May 16, 2024
3 checks passed
@silvester-pari silvester-pari deleted the map/fix/undefined-zoom branch May 16, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map initialization without zoom results in blank map few eox-map storybook configs are not working
2 participants