Skip to content

Commit

Permalink
Correct charm scaling for RoF
Browse files Browse the repository at this point in the history
Other clients should actually work the same as well
  • Loading branch information
mackal committed Nov 15, 2014
1 parent d33b320 commit 44bfdfe
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ EQEMu Changelog (Started on Sept 24, 2003 15:50)

== 11/14/2014 ==
Secrets: Identified object size and solidtype as flags. Exported them as functions to Perl.
demonstar55: Don't use the hack for charms that doesn't work on RoF

== 11/13/2014 ==
Kayen: Implemented target type (44) 'Beams' (which projects an AE infront of caster with a specified length and width).
Expand Down
5 changes: 3 additions & 2 deletions common/patches/rof.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4817,7 +4817,7 @@ namespace RoF

std::stringstream ss(std::stringstream::in | std::stringstream::out | std::stringstream::binary);

const Item_Struct *item = inst->GetItem();
const Item_Struct *item = inst->GetUnscaledItem();
//_log(NET__ERROR, "Serialize called for: %s", item->Name);

RoF::structs::ItemSerializationHeader hdr;
Expand All @@ -4839,7 +4839,7 @@ namespace RoF
hdr.price = inst->GetPrice();
hdr.merchant_slot = (merchant_slot == 0) ? 1 : inst->GetMerchantCount();
//hdr.merchant_slot = (merchant_slot == 0) ? 1 : 0xffffffff;
hdr.unknown020 = 0;
hdr.scaled_value = inst->IsScaling() ? inst->GetExp() / 100 : 0;
hdr.instance_id = (merchant_slot == 0) ? inst->GetSerialNumber() : merchant_slot;
hdr.unknown028 = 0;
hdr.last_cast_time = ((item->RecastDelay > 1) ? 1212693140 : 0);
Expand Down Expand Up @@ -5009,6 +5009,7 @@ namespace RoF
ibs.SpellShield = item->SpellShield;
ibs.Avoidance = item->Avoidance;
ibs.Accuracy = item->Accuracy;
ibs.CharmFileID = item->CharmFileID;
ibs.FactionAmt1 = item->FactionAmt1;
ibs.FactionMod1 = item->FactionMod1;
ibs.FactionAmt2 = item->FactionAmt2;
Expand Down
2 changes: 1 addition & 1 deletion common/patches/rof_structs.h
Original file line number Diff line number Diff line change
Expand Up @@ -4396,7 +4396,7 @@ struct ItemSerializationHeader
/*030*/ uint16 unknown013; // 0xffff
/*032*/ uint32 price;
/*036*/ uint32 merchant_slot; //1 if not a merchant item
/*040*/ uint32 unknown020; //0
/*040*/ uint32 scaled_value; //0
/*044*/ uint32 instance_id; //unique instance id if not merchant item, else is merchant slot
/*048*/ uint32 unknown028; //0
/*052*/ uint32 last_cast_time; // Unix Time from PP of last cast for this recast type if recast delay > 0
Expand Down

0 comments on commit 44bfdfe

Please sign in to comment.