New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spells] Implemented SPA 512 SE_Proc_Timer_Modifier, Fixed AA procs not working #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renamed function only check for buffs value > 0, don't need to check for AA's which are negative ID's
update var name to better represent its function.
added reuse timer
hgtw
reviewed
Oct 27, 2021
hgtw
approved these changes
Oct 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented SPA 512 SE_Proc_Timer_Modifier, this effect sets a reuse timer on combat procs after they cast. Ie. Every time Call of Fire is proced, it can not proc again for another 55 seconds (base=1, limit=55000). Set, base: 1, limit: time MS.
This can be applied to Spell Buff Melee Procs, Ranged Procs and Defensive Procs, as well AA versions of those effects.
Reimplemented AA proc effects. I discovered these were completely non-functional, unclear when they broke.
They are now fully functional, for all types of procs (Melee, Ranged, Defensive) and can apply SPA 512 to them as well.
Note you can have multiple different proc types (Melee, Ranged, Defensive) within the same AA or Spell and each can have it's own SPA 512 reuse timer. Just make sure you place the timer for each proc effect, after that proc effect. (Note: It will not work properly if you use 2 of the same type of proc in the same effect).
Example of a live AA that uses this and should be able to be fully replicated on eqemu now.
Fixed likely issue where pets would not retain ranged or defensive procs if unsuspended.
Fixed issue with twin proc not using correct logic.