Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spells] Implemented SPA 512 SE_Proc_Timer_Modifier, Fixed AA procs not working #1646

Merged
merged 26 commits into from Nov 5, 2021

Conversation

KayenEQ
Copy link
Contributor

@KayenEQ KayenEQ commented Oct 27, 2021

Implemented SPA 512 SE_Proc_Timer_Modifier, this effect sets a reuse timer on combat procs after they cast. Ie. Every time Call of Fire is proced, it can not proc again for another 55 seconds (base=1, limit=55000). Set, base: 1, limit: time MS.
This can be applied to Spell Buff Melee Procs, Ranged Procs and Defensive Procs, as well AA versions of those effects.

Reimplemented AA proc effects. I discovered these were completely non-functional, unclear when they broke.
They are now fully functional, for all types of procs (Melee, Ranged, Defensive) and can apply SPA 512 to them as well.

Note you can have multiple different proc types (Melee, Ranged, Defensive) within the same AA or Spell and each can have it's own SPA 512 reuse timer. Just make sure you place the timer for each proc effect, after that proc effect. (Note: It will not work properly if you use 2 of the same type of proc in the same effect).

Example of a live AA that uses this and should be able to be fully replicated on eqemu now.

AA Banestrike
1: Cast: Banestrike on Spell Use (40% Chance)
2: Limit Type: Detrimental
3: Limit Min Mana Cost: 10
4: Limit Target: Type 0
5: Limit Target: Line of Sight
6: Limit Target: Single
7: Limit Target: Lifetap
8: Limit Target: Targets Target
9: Limit Max Level: 254 (lose 100% per level)
10: Limit Effect: Current HP less than -100
11: Limit Class: ALL
12: Limit Min Delay Between Trigger: 60s (SPA 511)
13: Add Melee Proc: Banestrike with 100% Rate Mod
14: Proc Timer: 60s (SPA 512)
15: Add Range Proc: Banestrike with 100% Rate Mod
16: Proc Timer: 60s (SPA 512)
This passive ability allows your melee and damaging spells a chance to deal additional damage to creatures that you have mastered slaying once every 60 seconds.

Fixed likely issue where pets would not retain ranged or defensive procs if unsuspended.

Fixed issue with twin proc not using correct logic.

common/spdat.cpp Outdated Show resolved Hide resolved
@KayenEQ KayenEQ merged commit f1bfd6b into EQEmu:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants