[Bug Fix] Restore missing messages for lifetap and dmg spells. #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to ask that this be held open. While it does make things better, I have found some outstanding issues and I think I can make it better. |
|
Ok, found and fixed the one unintentional impact of this change. |
|
Assuming this is ready. |
Kinglykrab
approved these changes
Apr 13, 2022
Yep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when an npc (spectre) cast lifetap on a PC that the "feel your life drain away" message was missing.
This PR fixes this, and some other missing messages. It also uses the proper message Filters. This function had conflicting filters.
Been tested on Rolath for about a week. Have not seen any extra messages and missing messages are restored.