Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quest API] Add commify to Perl/Lua. #2099

Merged
merged 1 commit into from
May 3, 2022
Merged

Conversation

Kinglykrab
Copy link
Contributor

  • Add quest::commify(number) to Perl.
  • Add eq.commify(number) to Lua.

@Akkadius
Copy link
Member

Akkadius commented May 3, 2022

lgtm outside of small comment

@Kinglykrab
Copy link
Contributor Author

The rename is a bit needless. You can overload types in C so we could have two commify with different type inputs for both string and numbers

I only renamed it because when I had the questmgr and string_util method named the same it immediately crashed and I got an access violation.

@Akkadius
Copy link
Member

Akkadius commented May 3, 2022

You can access commify string util directly from within the lua / perl calls and skip creating a quest manager wrapper function

@Kinglykrab
Copy link
Contributor Author

You can access commify string util directly from within the lua / perl calls and skip creating a quest manager wrapper function

Will do.

- Add quest::commify(number) to Perl.
- Add eq.commify(number) to Lua.
@Kinglykrab
Copy link
Contributor Author

Done.

@Kinglykrab Kinglykrab merged commit 9b075c2 into master May 3, 2022
@Kinglykrab Kinglykrab deleted the quest_api/commify branch May 3, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants