[Bug Fix] Fix duplicate and missing messages due to innate in spells #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added code to use correct Range: rule based on type of message. |
|
Refined innate spell damage messages to only come out when "non-melee" damage wasn't coming out so we don't throw off parsers. Still preserving all new innate spell based messages (xyz was poisoned" etc.) |
Kinglykrab
reviewed
May 16, 2022
Kinglykrab
reviewed
May 16, 2022
Kinglykrab
approved these changes
May 18, 2022
|
This one looks good. Testing finding no bugs for several days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that some spells use skill_id 52 (innate) has caused confusion and multiple attempts at understanding why some messages are missing and some are duplicated.
This PR fixes spells that use skill_id 52 to send (2) messages to the person being damaged (attack.cpp)
Some of the above were being send by spells.cpp because attack.cpp was missing them.
This has been tested using lifetaps, DD, DD+DOT, DOT, root w/damage,etc.
It has been tested in PVP,, and npcs procing as well as casting,
I think more messages come out now (that we were missing) and all duplicates are gone.
Fingers crossed.
@nytmyr This fixes canni also..