Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Commands] Cleanup #spawneditmass Command. #2229

Merged
merged 3 commits into from
Jun 4, 2022
Merged

[Commands] Cleanup #spawneditmass Command. #2229

merged 3 commits into from
Jun 4, 2022

Conversation

Kinglykrab
Copy link
Contributor

  • Cleanup messages and logic.
  • Split command into its own file.

@Kinglykrab
[Commands] Cleanup #spawneditmass Command.
953b5f7 
- Cleanup messages and logic.
- Split command into its own file.
Akkadius
Akkadius approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@Akkadius Akkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these changes tested ?

@Kinglykrab
Copy link
Contributor Author

Were these changes tested ?

Yes. I can post screenshots and rebuild it.

@Kinglykrab Kinglykrab force-pushed the commands/spawneditmass_cleanup branch from b6f82c5 to 85b44ed Compare June 1, 2022 21:05
@Kinglykrab
Copy link
Contributor Author

Kinglykrab commented Jun 1, 2022 •
edited
Loading

Modified code to not run query if the user is not using a supported option (currently only respawn_time).

Before #spawneditmass Guard respawn_time 5
image

Using #spawneditmass Guard respawn_time 5 then the #spawneditmass Guard respawn_time 5 apply saylink
image

After #spawneditmass Guard respawn_time 5 apply
image

@Kinglykrab Kinglykrab requested a review from Akkadius June 1, 2022 21:17
@Akkadius
Copy link
Member

Akkadius commented Jun 1, 2022

Looks good, would really prefer to see one line per spawn / npc like other mass commands

@Kinglykrab
Copy link
Contributor Author

Kinglykrab commented Jun 1, 2022 •
edited
Loading

Looks good, would really prefer to see one line per spawn / npc like other mass commands

Figured it was cleaner since all of it on one line would wrap and be harder to read. Can put it in one if you want.

@Akkadius Akkadius merged commit 17034a6 into master Jun 4, 2022
@Akkadius Akkadius deleted the commands/spawneditmass_cleanup branch June 4, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akkadius Akkadius Akkadius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kinglykrab @Akkadius