[Rules] Add adjustment for zone forage. #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fryguy503
commented
Jul 29, 2022
fryguy503
commented
- Added rule to allow the adjustment of zone foraging %
- Added rule to allow the adjustment of zone foraging %
Kinglykrab
reviewed
Jul 29, 2022
zone/forage.cpp
Outdated
| @@ -457,37 +456,38 @@ void Client::ForageItem(bool guarantee) { | |||
| return; | |||
| } | |||
|
|
|||
| if(foragedfood == 13106) | |||
| if(foragedfood == 13106) { | |||
There was a problem hiding this comment.
Can we make this a constant?
There was a problem hiding this comment.
FOOD_FISHING_GRUBS or something.
|
|
Kinglykrab
approved these changes
Jul 29, 2022
|
Our forage and fishing tables are so fucking wrong. Server/common/patches/rof2_structs.h Line 596 in 4002d6a |
mackal
approved these changes
Jul 29, 2022
Akkadius
approved these changes
Jul 30, 2022
mackal
pushed a commit
that referenced
this pull request
Sep 3, 2022
* [Rules] Add adjustment for zone forage. - Added rule to allow the adjustment of zone foraging % * Cleanup if formating
catapultam-habeo
pushed a commit
to catapultam-habeo/pyrelight-server
that referenced
this pull request
Mar 27, 2023
* [Rules] Add adjustment for zone forage. - Added rule to allow the adjustment of zone foraging % * Cleanup if formating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.