[Tasks] Make #task reloadall not quit shared tasks #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing #task reloadall to desync state for shared tasks. Characters were removed from the shared task but remained in the character_tasks table. This CancelTask is cosmetic only to reload the client window.
mackal
approved these changes
Jul 31, 2022
Kinglykrab
changed the title
Akkadius
approved these changes
Jul 31, 2022
mackal
pushed a commit
that referenced
this pull request
Sep 3, 2022
This was causing #task reloadall to desync state for shared tasks. Characters were removed from the shared task but remained in the character_tasks table. This CancelTask is cosmetic only to reload the client window.
catapultam-habeo
pushed a commit
to catapultam-habeo/pyrelight-server
that referenced
this pull request
Mar 27, 2023
This was causing #task reloadall to desync state for shared tasks. Characters were removed from the shared task but remained in the character_tasks table. This CancelTask is cosmetic only to reload the client window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing #task reloadall to desync state for shared tasks.
Characters were removed from the shared task but remained in the
character_tasks table. This CancelTask is cosmetic only to reload
the client window.