Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crash] Websocket Crash fix race when fetching log categories #2456

Merged
merged 2 commits into from
Sep 29, 2022
Merged

[Crash] Websocket Crash fix race when fetching log categories #2456

merged 2 commits into from
Sep 29, 2022

Conversation

Akkadius
Copy link
Member

Trace

[09-28-2022 20:38:31] [Zone] [Crash] C:\Code\Server\zone\zone.h (173): Zone::GetZoneID 
[09-28-2022 20:38:31] [Zone] [Crash] C:\Code\Server\zone\api_service.cpp (832): ApiGetLogsysCategories 
[09-28-2022 20:38:31] [Zone] [Crash] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\type_traits (1558): std::invoke<Json::Value (__cdecl*&)(EQ::Net::WebsocketServerConnection *,Json::Value),EQ::Net::WebsocketServerConnection *,Json::Value const &> 
[09-28-2022 20:38:31] [Zone] [Crash] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\functional (670): std::_Invoker_ret<Json::Value>::_Call<Json::Value (__cdecl*&)(EQ::Net::WebsocketServerConnection *,Json::Value),EQ::Net::WebsocketServerConnection *,Json::Value const &> 
[09-28-2022 20:38:31] [Zone] [Crash] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\functional (831): std::_Func_impl_no_alloc<Json::Value (__cdecl*)(EQ::Net::WebsocketServerConnection *,Json::Value),Json::Value,EQ::Net::WebsocketServerConnection *,Json::Value const &>::_Do_call 
[09-28-2022 20:38:31] [Zone] [Crash] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\functional (878): std::_Func_class<Json::Value,EQ::Net::WebsocketServerConnection *,Json::Value const &>::operator() 
[09-28-2022 20:38:31] [Zone] [Crash] C:\Code\Server\common\net\websocket_server.cpp (119): EQ::Net::WebsocketServer::HandleRequest

@Akkadius Akkadius merged commit c1626da into master Sep 29, 2022
@Akkadius Akkadius deleted the akkadius/websocket-crash-fix branch September 29, 2022 02:29
catapultam-habeo pushed a commit to catapultam-habeo/pyrelight-server that referenced this pull request Mar 27, 2023
@Akkadius @catapultam-habeo
[Crash] Websocket Crash fix race when fetching log categories (EQEmu#…
f65f6e4 
…2456)

* [Crash] Websocket crash fix race

* Refine check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kinglykrab Kinglykrab Kinglykrab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Akkadius @Kinglykrab