Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libuv] Bump to v1.44.2 from v1.26.0 #2658

Merged
merged 1 commit into from Dec 20, 2022
Merged

[libuv] Bump to v1.44.2 from v1.26.0 #2658

merged 1 commit into from Dec 20, 2022

Conversation

Akkadius
Copy link
Member

@Akkadius Akkadius commented Dec 20, 2022

Changes libuv/libuv@v1.26.0...v1.44.2

Addresses compile time warnings noted here libuv/libuv#2418

And also shown in our build. Tested and working well

../submodules/libuv/src/unix/thread.c: In function 'uv_thread_create_ex':
../submodules/libuv/src/unix/thread.c:236:35: warning: cast between incompatible function types from 'void (*)(void *)' to 'void * (*)(void *)' [-Wcast-function-type]
  236 |   err = pthread_create(tid, attr, (void*(*)(void*)) entry, arg);
      |                                   ^
[160/539] Building C object submodules/libuv/CMakeFiles/uv_a.dir/src/unix/signal.c.o
../submodules/libuv/src/unix/signal.c: In function 'uv__signal_stop':
../submodules/libuv/src/unix/signal.c:542:7: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
  542 |   int ret;
      |       ^~~
[168/539] Building C object submodules/libuv/CMakeFiles/uv_a.dir/src/unix/linux-core.c.o
../submodules/libuv/src/unix/linux-core.c: In function 'uv__io_poll':
../submodules/libuv/src/unix/linux-core.c:321:5: warning: converting a packed 'struct epoll_event' pointer (alignment 1) to a 'uv__io_t' {aka 'struct uv__io_s'} pointer (alignment 8) may result in an unaligned pointer value [-Waddress-of-packed-member]
  321 |     loop->watchers[loop->nwatchers] = (void*) events;
      |     ^~~~
In file included from ../submodules/libuv/src/unix/linux-core.c:37:
/usr/include/x86_64-linux-gnu/sys/epoll.h:83:8: note: defined here
   83 | struct epoll_event
      |        ^~~~~~~~~~~
In file included from ../submodules/libuv/include/uv.h:62,
                 from ../submodules/libuv/src/unix/linux-core.c:26:
../submodules/libuv/include/uv/unix.h:92:8: note: defined here
   92 | struct uv__io_s {
      |        ^~~~~~~~
[189/539] Building C object submodules/libuv/CMakeFiles/uv.dir/src/unix/thread.c.o
../submodules/libuv/src/unix/thread.c: In function 'uv_thread_create_ex':
../submodules/libuv/src/unix/thread.c:236:35: warning: cast between incompatible function types from 'void (*)(void *)' to 'void * (*)(void *)' [-Wcast-function-type]
  236 |   err = pthread_create(tid, attr, (void*(*)(void*)) entry, arg);
      |                                   ^
[192/539] Building C object submodules/libuv/CMakeFiles/uv.dir/src/unix/signal.c.o
../submodules/libuv/src/unix/signal.c: In function 'uv__signal_stop':
../submodules/libuv/src/unix/signal.c:542:7: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
  542 |   int ret;
      |       ^~~
[207/539] Building C object submodules/libuv/CMakeFiles/uv.dir/src/unix/linux-core.c.o
../submodules/libuv/src/unix/linux-core.c: In function 'uv__io_poll':
../submodules/libuv/src/unix/linux-core.c:321:5: warning: converting a packed 'struct epoll_event' pointer (alignment 1) to a 'uv__io_t' {aka 'struct uv__io_s'} pointer (alignment 8) may result in an unaligned pointer value [-Waddress-of-packed-member]
  321 |     loop->watchers[loop->nwatchers] = (void*) events;
      |     ^~~~
In file included from ../submodules/libuv/src/unix/linux-core.c:37:
/usr/include/x86_64-linux-gnu/sys/epoll.h:83:8: note: defined here
   83 | struct epoll_event
      |        ^~~~~~~~~~~
In file included from ../submodules/libuv/include/uv.h:62,
                 from ../submodules/libuv/src/unix/linux-core.c:26:
../submodules/libuv/include/uv/unix.h:92:8: note: defined here
   92 | struct uv__io_s {
      |        ^~~~~~~~

We get a clean build now

@Akkadius Akkadius changed the title libuv] Bump to v1.44.2 from v1.26.0 [libuv] Bump to v1.44.2 from v1.26.0 Dec 20, 2022
@Akkadius Akkadius requested review from hgtw and KimLS December 20, 2022 01:08
@Akkadius Akkadius merged commit 4ea38bf into master Dec 20, 2022
@Akkadius Akkadius deleted the akkadius/libuv-bump branch December 20, 2022 19:12
catapultam-habeo pushed a commit to catapultam-habeo/pyrelight-server that referenced this pull request Mar 27, 2023
chazix added a commit to chazix/EQMacEmu that referenced this pull request Nov 8, 2023
chazix added a commit to chazix/EQMacEmu that referenced this pull request Nov 8, 2023
SecretsOTheP added a commit to SecretsOTheP/EQMacEmu that referenced this pull request Nov 8, 2023
chazix added a commit to chazix/EQMacEmu that referenced this pull request Nov 9, 2023
chazix added a commit to chazix/EQMacEmu that referenced this pull request Nov 20, 2023
regneq added a commit to EQMacEmu/Server that referenced this pull request Nov 20, 2023
[libuv] Bump to v1.44.2 from v1.26.0 (EQEmu/Server#2658)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants