[QS] Database class name change #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kinglykrab
approved these changes
Jan 15, 2023
catapultam-habeo
pushed a commit
to catapultam-habeo/pyrelight-server
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Similar to #2742. Work done already in the player eventing branch to be PR'ed soon.
This PR addresses an issue that prevents developers from using repositories within QS because it clashes with
./common/database.hDatabaseclass.Similarly to
ZoneDatabaseandWorldDatabaseQS's database was renamed fromDatabasetoQSDatabaseand inheritsDatabaseso it can use commonly leveraged connect, disconnect logic that was copy and pasted way back