Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code] Removed vscode settings #2753

Merged
merged 1 commit into from Jan 17, 2023
Merged

[Code] Removed vscode settings #2753

merged 1 commit into from Jan 17, 2023

Conversation

xackery
Copy link
Contributor

@xackery xackery commented Jan 17, 2023

This removes the .vscode and .devcontainer folders

@xackery xackery requested a review from Aeadoin January 17, 2023 19:04
@xackery xackery mentioned this pull request Jan 17, 2023
Closed
@Akkadius Akkadius changed the title Removed vscode settings [Code] Removed vscode settings Jan 17, 2023
Akkadius
Akkadius approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@Akkadius Akkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

If there are docs that folks can create as to show what works best for them in their development flows - that would help empower others

@Akkadius Akkadius merged commit a90c760 into master Jan 17, 2023
@Akkadius Akkadius deleted the xackery/vscodesettings branch January 17, 2023 21:20
@Kinglykrab
Copy link
Contributor

Should we add .devcontainer to ignore as well?

catapultam-habeo pushed a commit to catapultam-habeo/pyrelight-server that referenced this pull request Mar 27, 2023
@xackery @catapultam-habeo
[Code] Removed vscode setting (EQEmu#2753)
e1d780e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akkadius Akkadius Akkadius approved these changes

@Aeadoin Aeadoin Aeadoin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xackery @Kinglykrab @Akkadius @Aeadoin